Skip to content

rubocop -a #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rubocop -a #1053

wants to merge 1 commit into from

Conversation

@apiology
Copy link
Contributor

@apiology apiology commented Aug 30, 2025 •
edited
Loading

This PR was generated by this script - rerun to autogenerate (the PR will collect conflicts pretty regularly until it's merged):

  1. First, reset the branch to be the same as master:
# Error out instead of continuing
set -e
# Reset any existing commits out
git checkout rubocop_a
git fetch -a
git reset --hard origin/master
  1. apply the autocorrect:
# Tell RuboCop not to prepend unused arguments with `_`, leaving Solargraph params unlinked
gsed -i 's/^  AllowUnusedKeywordArguments: true/  Enabled: false/g' .rubocop.yml
# Tell RuboCop not to use syntax that Solargraph doesn't understand yet
yq eval '.["Style/ArgumentsForwarding"].Enabled = false' -i .rubocop.yml
yq eval '.["Style/SuperArguments"].Enabled = false' -i .rubocop.yml
# Run autocorrect and push up changes:
rm .rubocop_todo.yml
touch .rubocop_todo.yml
bundle exec rubocop -a -c .rubocop.yml || true
git checkout .rubocop.yml # revert rule change
git checkout spec/fixtures # leave these alone
bundle exec rubocop --auto-gen-config --no-exclude-limit --no-offense-counts --no-auto-gen-timestamp
git commit -a -m "rubocop -a"
  1. Now push up and replace previous commits:
git push -f

The solargraph overcommit errors are limitations in our strong typechecking, mostly if not all addressed by other open PRs.

After this PR is merged, other PRs will need to apply step 2 before merging master in to make that merge happen smoothly.

@apiology apiology force-pushed the rubocop_a branch 5 times, most recently from 752d955 to 7fdc00f Compare August 31, 2025 00:49
@apiology apiology marked this pull request as ready for review August 31, 2025 01:01
@apiology apiology force-pushed the rubocop_a branch 2 times, most recently from cdfacc5 to 2cd6522 Compare September 7, 2025 20:51
@apiology apiology force-pushed the rubocop_a branch 2 times, most recently from 007da03 to 15225c3 Compare September 23, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@apiology